replaced asterisk string literal occurrences with constant

[haiderashfaq]

resolves #2343

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Submitter Checklist:

• Include a link to the related GitHub issue, if applicable
• Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

• Perform code review
• Add performance label
• Perform appropriate level of performance testing
• Confirm all checks passed
• Add version label prior to acceptance

[fallwith]

Hi @haiderashfaq,

Thanks very much for your PR! These changes will help keep object allocation and garbage collection sweeps down to improve performance and are very much appreciated.

It looks like the change to lib/new_relic/agent/instrumentation/sinatra/ignorer.rb caused some unit test failures.

Would you please the following change?

- routes = [ASTERISK] if routes.empty?
+ routes = [::NewRelic::ASTERISK] if routes.empty?

That should fix it. None of the other files changed caused any test failures, so all of those other changes are good as-is.

[fallwith]

Thank you for your contribution, @haiderashfaq! This change will go out with the next agent release.