Rebase latest changes from dev into k2 #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 9.3.0
Release 9.3.1
Release 9.4.0
Release 9.4.1
Release 9.4.2
Release 9.5.0
use the latest stable JRuby for JRuby tests
For the `async_http` multiverse suite: - ignore JRuby, as it can not work with the required native extensions - ignore expected errors instead of having them hit STDOUT
for JRuby, allow multiple seen errors
for JRuby permit the odd extra event
relax assertions for JRuby, while still verifying the same object in the same way as CRuby
…to abstract parent class
standardize on relaxing JRuby assertions for all collector calls
update `first_call_for` usage
Release 9.6.0
Change rubocop to 1.57.2, as 1.54 breaks an installation using bundler 1.17, fix was posted to robucop and a new release was created.
Autocorrections applied by Rubocop v1.57.2 after upgrading from v1.54
Update newrelic_rpm.gemspec
Fixes the consistency for the capitalization of 'Agent' -> 'agent' across the project
Update `CONTIBUTING.md` to remove the reference to the Slack workspace
CONTRIBUTING.md - remove Slack workspace mention
Infinite Tracing depends on the `grpc` gem, which requires Ruby 2.5+. Frequently, the gRPC Ruby gem maintainers inadvertently break compatibility with Ruby 2.5 and 2.6 by publishing a new version of `google-protobuf` (which `grpc` depends on) that itself requires Ruby 2.7+. We do not wish to pin our `grpc` dependency to an exact version that is known to be compatible with Ruby 2.5 and Ruby 2.6 so that we leave users free to use whatever 1.x version of `grpc` that they wish, especially if they are themselves using `grpc` in their application. Whether the gRPC maintainers' frequent breaking of Ruby 2.5 and 2.6 compatibility is accidental or deliberate, supporting these Rubies with our CI system has simply caused too many issues. We are not actively introducing any new Ruby code to Infinite Tracing that could break Ruby 2.5 and 2.6 compatibility, so we will switch to manual testing of these Rubies as appropriate moving forward.
…mes bin/newrelic -> bin/newrelic_rpm
Co-authored-by: James Bunch <[email protected]>
Refactor local_environment methods
Inline disable rubocop Cleanup tests Appease rubocop
Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Code feedback Add mistakenly deleted file Move file Test update Test updates Use newer vc version
version change Only test latest version
Version fix
Remove Ruby/Thread and Ruby/Fiber spans
ViewComponent instrumentation
Prerelease 9.7.0-pre
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
prateeksen
requested review from
fallwith,
hannahramadan,
kaylareopelle and
tannalynn
as code owners
github-actions
bot
added
the
community
fallwith
approved these changes
Jan 11, 2024
…tion_if_newrelic_traces Skip Async-http instrumentation installation when Traces::Backend::NewRelic is defined
SimpleCov Report
|
kaylareopelle
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist