Update LLM event attributes #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
The specification has changed since we initially created LLM events. This PR updates the attributes to reflect the current spec. Removes: api_key_last_four_digits transaction_id Adds: assertion for request.temperature
kaylareopelle
force-pushed
the
remove_api_key_attr
branch
from
5accc18 to
475225e
Compare
kaylareopelle
changed the title
api_key_last_four_digits from LLM events
SimpleCov Report
|
| assert_equal '789', attributes['request_id'] | ||
| assert_equal 25, attributes['conversation_id'] # needs to be removed, see #2437 |
There was a problem hiding this comment.
thanks for this comment ◡̈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification has changed since we initially created LLM events.
This PR updates the attributes to reflect the current spec.
Removes:
api_key_last_four_digits
transaction_id
Adds:
assertion for request.temperature
Closes #2459