Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embeddings tests #2481

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Embeddings tests #2481

merged 3 commits into from
Mar 4, 2024

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Mar 4, 2024 •
edited
Loading

Change embedding tests to use embedding object.

@hannahramadan hannahramadan changed the base branch from dev to openai_instrumentation March 4, 2024 23:02
@hannahramadan hannahramadan marked this pull request as ready for review March 4, 2024 23:23
@hannahramadan hannahramadan merged commit 78e6a81 into openai_instrumentation Mar 4, 2024
27 checks passed
@hannahramadan hannahramadan deleted the embeddings_tests branch March 4, 2024 23:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

SimpleCov Report

Coverage Threshold
Line 93.69% 93%
Branch 71.35% 71%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kreopelle kreopelle kreopelle approved these changes

@fallwith fallwith Awaiting requested review from fallwith

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle

@tannalynn tannalynn Awaiting requested review from tannalynn

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahramadan @kreopelle