Configuration option: ai_monitoring.record_content.enabled
#2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
commented
Mar 5, 2024
hannahramadan
commented
Mar 5, 2024
lib/new_relic/agent/instrumentation/ruby_openai/instrumentation.rb
Outdated
Show resolved
Hide resolved
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
fallwith
reviewed
Mar 5, 2024
lib/new_relic/agent/instrumentation/ruby_openai/instrumentation.rb
Outdated
Show resolved
Hide resolved
lib/new_relic/agent/instrumentation/ruby_openai/instrumentation.rb
Outdated
Show resolved
Hide resolved
fallwith
approved these changes
Mar 6, 2024
lib/new_relic/agent/instrumentation/ruby_openai/instrumentation.rb
Outdated
Show resolved
Hide resolved
lib/new_relic/agent/instrumentation/ruby_openai/instrumentation.rb
Outdated
Show resolved
Hide resolved
kaylareopelle
approved these changes
Mar 8, 2024
…n.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new configuration option,
ai_monitoring.record_content.enabled, that when disabled, the agent removes certain content before sending LLM events, specifically:name:
ai_monitoring.record_content.enableddefault:
trueSpec (Internal)
Note per the spec, the following should also be removed (we aren't recording these as of now—noting here for completness):
closes #2452