Create set_llm_token_count_callback API
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API accepts one argument, a proc, that should contain the callback the agent will invoke if it cannot glean the token count from instrumentation. A supportability metric is recorded when the API is called.
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
approved these changes
Mar 5, 2024
Your work on the error callback made this easy! |
lib/new_relic/agent.rb
Outdated
| # | ||
| # @param callback_proc [Proc] the callback proc | ||
| # | ||
| # Typically this method should be called only once to set a callback for |
There was a problem hiding this comment.
Do we need the word 'typically'?
There was a problem hiding this comment.
I don't think so. This documentation was drawn from another one of our APIs. I'll remove!
hannahramadan
approved these changes
Mar 6, 2024
kaylareopelle
commented
Mar 6, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API accepts one argument, a proc, that should contain the callback the agent will invoke if it cannot glean the token count from instrumentation.
A supportability metric is recorded when the API is called.
Closes: #2451