Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize config hash #2490

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Synchronize config hash #2490

merged 1 commit into from
Mar 9, 2024

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Mar 7, 2024 •
edited
Loading

The use of JRuby revealed a synchronization issue of threads accessing/editing configuration. Adding a 'synchronize do' block to mediate this.

@hannahramadan
Synchronize config hash
51fecd4 
The use of JRuby revealed a synchronize issue of threads accessing/editing configuration values simultaneously. Adding a 'synchronize do' block fixes this.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

SimpleCov Report

Coverage Threshold
Line 93.73% 93%
Branch 71.76% 71%

@fallwith fallwith marked this pull request as ready for review March 8, 2024 21:38
@fallwith
Copy link
Contributor

fallwith commented Mar 8, 2024

NOTE: #2282 replaced the lock and went with a #dup instead. We currently feel that we still need that #dup for a separate issue that can be reproduced with our JRuby CI. This approach of layering on both the lock and the #dup is intentional and approved.

@hannahramadan hannahramadan merged commit e7a0abf into dev Mar 9, 2024
117 checks passed
@hannahramadan hannahramadan deleted the sychronize_config_hash branch March 9, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannalynn tannalynn tannalynn approved these changes

@fallwith fallwith fallwith approved these changes

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hannahramadan @fallwith @tannalynn