OpenAI: Final spec review/changes #2514

hannahramadan · 2024-03-18T16:32:12Z

Some finishing touches after walking through the spec:

DT needs to be enabled in order to use the record_feedback API
ai_monitoring.enabled should be false by default
Small refactors for recording metrics
We no longer need to drop the llm. prefix from custom attributes
Because AI monitoring is diabled by default, we enabled it in newrelic.yml for testing

- Include `llm.` prefix on custom attributes - Small refactors

github-actions · 2024-03-18T16:56:30Z

SimpleCov Report

	Coverage	Threshold
Line	93.72%	93%
Branch	71.2%	71%

hannahramadan added 2 commits March 18, 2024 08:42

Changes include:

347f4be

- Include `llm.` prefix on custom attributes - Small refactors

Disable ai_monitoring by default, add some tests

b2c1cee

hannahramadan changed the base branch from dev to openai_instrumentation March 18, 2024 16:32

Set ai_monitoring to true for tests

bbf942e

hannahramadan changed the title ~~Spec review~~ OpenAI: Final spec review/changes Mar 18, 2024

hannahramadan marked this pull request as ready for review March 18, 2024 23:22

hannahramadan requested review from fallwith, kaylareopelle and tannalynn as code owners March 18, 2024 23:22

kaylareopelle approved these changes Mar 19, 2024

View reviewed changes

hannahramadan merged commit 3696ea7 into openai_instrumentation Mar 19, 2024
28 checks passed

hannahramadan deleted the spec_review branch April 12, 2024 19:28