-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serverless updates, including support for v1 payload formats #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch from payload format v2 to v1 to align with the other dynamic language based agents - don't send log event data - remove metadata attributes not used by the Node.js agent
more serverless handler changes for output format v1, agent attributes work
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
March 23, 2024 02:08
write instead of puts, debug output
`Base64.encode64` -> `Base64.strict_encode64`
kaylareopelle
approved these changes
Mar 27, 2024
serverless: go more efficient with metric_data
- make sure errors are converted into the collector format - restore the log_event_data section
the error_data arrays must themselves be in an array as the second element (the first being the agent run id)
the two item array and two argument method call got a bit mixed up
support for these could potentially be added in the future if we could adapt the data normalization process to them
don't check for serverless with a disabled agent
use an env var to por que no los dos toda la cosa
fallwith
changed the title
serverless - use output payload v1 format
serverless updates, including support for v1 payload formats
Mar 29, 2024
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metric_data
anderror_data