Event attribute validation #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
hannahramadan
commented
Mar 28, 2024
| @@ -158,7 +230,7 @@ def test_llm_custom_attributes_added_to_embedding_events | |||
| 'triceratops' => 'herbivore' | |||
| }) | |||
| stub_post_request do | |||
| client.embeddings(parameters: chat_params) | |||
| client.embeddings(parameters: embeddings_params) | |||
There was a problem hiding this comment.
This test is ensuring llm. custom events are added. This change doesn't affect the test, but it always should've been embeddings_params.
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
fallwith
reviewed
Mar 28, 2024
Co-authored-by: James Bunch <[email protected]>
fallwith
reviewed
Mar 28, 2024
| assert attributes['request.model'] | ||
| assert attributes['response.choices.finish_reason'] | ||
| assert attributes['request.temperature'] | ||
| assert attributes['duration'] |
There was a problem hiding this comment.
Does assert ensure that each of the values would survive an #empty? check or simply a #nil? one?
There was a problem hiding this comment.
Great callout. I'll change these asserts to refute_empty for the hash values.
fallwith
previously approved these changes
Mar 28, 2024
kaylareopelle
previously approved these changes
Mar 29, 2024
test/multiverse/suites/ruby_openai/ruby_openai_instrumentation_test.rb
Outdated
Show resolved
Hide resolved
hannahramadan
dismissed stale reviews from kaylareopelle and fallwith
via
3585f2d
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
SimpleCov Report
|
fallwith
approved these changes
Mar 29, 2024
kaylareopelle
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to validate the desired attributed exist on chat completion, message, and embedding events.
Through testing, it was discovered that the
request_temperatureon chat completion events was not being assigned. That has been fix and a CHANGELOG reflects this change.closes #2440