simplify tests for AI header setting / not setting #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a variable in combination with a proc to confirm the stubbed method
was indeed invoked as expected or not invoked as expected.
this gives us an assertion in the non-invoked path, which is nice.
i believe this fixes (switching from `-> {}` to `proc { |_h| }` an issue
to where if the `raise` actually was attempted in the non-invoked path,
it would fail.
removed unused variables / mocks
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
kaylareopelle
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a variable in combination with a proc to confirm the stubbed method was indeed invoked as expected or not invoked as expected.
this gives us an assertion in the non-invoked path, which is nice.
i believe this fixes (switching from
-> {}toproc { |_h| }an issue to where if theraiseactually was attempted in the non-invoked path, it would fail.removed unused variables / mocks