Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for AWS account id #2904

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Add config option for AWS account id #2904

merged 11 commits into from
Oct 22, 2024

Conversation

tannalynn
Copy link
Contributor

@tannalynn tannalynn commented Oct 9, 2024

Adds a config option cloud.aws.account_id that will allow customers to set their associated AWS account ID to provide more details and improve entity relationships in the UI. Currently, the only instrumentation using this is DynamoDB

resolves #2895
resolves #2896

@tannalynn tannalynn marked this pull request as ready for review October 10, 2024 16:08
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/new_relic/agent/configuration/default_source.rb Outdated Show resolved Hide resolved
fallwith
fallwith previously approved these changes Oct 21, 2024
kaylareopelle
kaylareopelle previously approved these changes Oct 21, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Kayla Reopelle <[email protected]>
@tannalynn tannalynn dismissed stale reviews from kaylareopelle and fallwith via c8f18d4 October 21, 2024 18:18
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.81% 93%
Branch 69.71% 50%

@tannalynn tannalynn merged commit 56889c5 into dev Oct 22, 2024
34 checks passed
@tannalynn tannalynn deleted the add_aws_account_id_config branch November 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants