Add backtrace line 0 to 3.4 ERB failure logs #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 no longer provides the line number in the exception message for the error raised by a failure to parse ERB in the newrelic.yml file. To help our customers with debugging, add the line number to the output by printing the first line of the backtrace for the exception to the agent logs Resolves #2902
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
tannalynn
previously approved these changes
Dec 11, 2024
tannalynn
previously approved these changes
Dec 11, 2024
SimpleCov Report
|
tannalynn
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 no longer provides the line number in the exception message for the error raised by a failure to parse ERB in the newrelic.yml file.
To help our customers with debugging, add the line number to the output by printing the first line of the backtrace for the exception to the agent logs
Resolves #2902
Full CI: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12285237901
Also, we removed branch coverage because there's a bug in Ruby 3.4's version of the prism parser that causes suites to silently fail when simplecov runs: https://bugs.ruby-lang.org/issues/20866