Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use permalink for Logger::Severity #3013

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ Version 9.3.0 of the agent adds log-level filtering, adds custom attributes for
| --------------------------- | ------- | ------------------------------------------------------ | ------ |
| `application_logging.forwarding.log_level` | `debug` | Sets the minimum log level for events forwarded to New Relic | `debug`, `info`, `warn`, `error`, `fatal`, `unknown` |

This setting uses [Ruby's Logger::Severity constants integer values](https://github.com/ruby/ruby/blob/master/lib/logger/severity.rb#L6-L17) to determine precedence.
This setting uses [Ruby's Logger::Severity constants integer values](https://github.com/ruby/logger/blob/113b82a06b3076b93a71cd467e1605b23afb3088/lib/logger/severity.rb#L6-L17) to determine precedence.

- **Feature: Custom attributes for logs**

Expand Down
2 changes: 1 addition & 1 deletion lib/new_relic/agent/configuration/default_source.rb
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil)
:description => <<~DESCRIPTION
Sets the minimum level a log event must have to be forwarded to New Relic.

This is based on the integer values of Ruby's `Logger::Severity` constants: https://github.com/ruby/ruby/blob/master/lib/logger/severity.rb
This is based on the integer values of [Ruby's `Logger::Severity` constants](https://github.com/ruby/logger/blob/113b82a06b3076b93a71cd467e1605b23afb3088/lib/logger/severity.rb).

The intention is to forward logs with the level given to the configuration, as well as any logs with a higher level of severity.

Expand Down
4 changes: 2 additions & 2 deletions newrelic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ common: &default_settings

# Sets the minimum level a log event must have to be forwarded to New Relic.
# This is based on the integer values of Ruby's Logger::Severity constants:
# https://github.com/ruby/ruby/blob/master/lib/logger/severity.rb
# https://github.com/ruby/logger/blob/113b82a06b3076b93a71cd467e1605b23afb3088/lib/logger/severity.rb
# The intention is to forward logs with the level given to the configuration, as
# well as any logs with a higher level of severity.
# For example, setting this value to "debug" will forward all log events to New
Expand Down Expand Up @@ -949,7 +949,7 @@ common: &default_settings
# NOTE: All "security.*" configuration parameters are related only to the
# security agent, and all other configuration parameters that may
# have "security" in the name somewhere are related to the APM agent.

# If true, the security agent loads (the agent performs a Ruby 'require')
# security.agent.enabled: false

Expand Down
Loading