-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures for typhoeus on jruby #812
Conversation
jruby in new ethon version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Tanna! One edit suggestion for the ethon PR - you mention JRuby 9.2.9.0. Though that's what you're running locally, we're testing the CI against 9.2.19.0. I think they might want to know the regression is happening in this more recent version too.
378a510
Great point, I added the CI jruby version to that issue as well. |
( racc 1.6.0 bugged on jruby)
Today, a totally different gem (racc) released a new version that is unable to be installed on jruby, causing unit test failures. To resolve this, I've pinned the racc version to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
Before contributing, please read our contributing guidelines and code of conduct.
Overview
The new ethon version 0.15.0 used by typhoeus causes errors on jruby. This PR pins the ethon version to 0.14.0 so that we can get our CI running green again.
I created an issue in the ethon repository to report this issue typhoeus/ethon#205
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist