Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures for typhoeus on jruby #812

Merged
merged 5 commits into from
Oct 19, 2021
Merged

Conversation

tannalynn
Copy link
Contributor

Before contributing, please read our contributing guidelines and code of conduct.

Overview

The new ethon version 0.15.0 used by typhoeus causes errors on jruby. This PR pins the ethon version to 0.14.0 so that we can get our CI running green again.

I created an issue in the ethon repository to report this issue typhoeus/ethon#205

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@amhuntsman amhuntsman self-requested a review October 19, 2021 18:55
amhuntsman
amhuntsman previously approved these changes Oct 19, 2021
@amhuntsman amhuntsman self-requested a review October 19, 2021 18:55
kaylareopelle
kaylareopelle previously approved these changes Oct 19, 2021
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tanna! One edit suggestion for the ethon PR - you mention JRuby 9.2.9.0. Though that's what you're running locally, we're testing the CI against 9.2.19.0. I think they might want to know the regression is happening in this more recent version too.

@tannalynn tannalynn dismissed stale reviews from kaylareopelle and amhuntsman via 378a510 October 19, 2021 19:08
@tannalynn
Copy link
Contributor Author

tannalynn commented Oct 19, 2021

Thanks, Tanna! One edit suggestion for the ethon PR - you mention JRuby 9.2.9.0. Though that's what you're running locally, we're testing the CI against 9.2.19.0. I think they might want to know the regression is happening in this more recent version too.

Great point, I added the CI jruby version to that issue as well.

@tannalynn
Copy link
Contributor Author

tannalynn commented Oct 19, 2021

Today, a totally different gem (racc) released a new version that is unable to be installed on jruby, causing unit test failures. To resolve this, I've pinned the racc version to <=1 .5.2 on jruby in the failing test suites, which is the last version that works on jruby. There has already been an issue opened about this ruby/racc#172

@kaylareopelle kaylareopelle self-requested a review October 19, 2021 20:51
kaylareopelle
kaylareopelle previously approved these changes Oct 19, 2021
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@tannalynn tannalynn merged commit 231b757 into dev Oct 19, 2021
@kaylareopelle kaylareopelle deleted the fix_jruby_typheous_failure branch November 29, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants