Feat performance monitoring #189

rahulreddy15 · 2025-01-02T10:58:45Z

PR to merge performance monitoring code from the fork to the branch epic_db_query_performance_monitoring

CLAassistant · 2025-01-02T10:58:52Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 5 committers have signed the CLA.

✅ tharun0064
✅ rahulreddy15
✅ sjyothi54
❌ newrelic-coreint-bot
❌ renovate[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

rajrohanyadav

Hi, I only reviewed the new code, and would not have 100% confidence on any impacts on the older code. Therefore, additional reviews would be required.

As pointed by the linter, some files are not formatted correctly.
It is difficult to assert and understand the logic without any comments or unit tests. Can we please add unit tests for all logical functions and utils. Please add any comments helpful to understand what's going on :).
I also see some code duplication as pointed by the linter as well. We should check if that can be removed.
If we can, I think it can be refactored to only check for version once as the integration is running for a single DBMS, and build our struct based on that, which can still have the same functions for getting query metrics. But use different adapters based on the version. This could remove some duplication and improve readability.
It would be helpful if the PR description is updated with some more details and testing details.

Thanks

go.mod

src/args/argument_list.go

src/main.go

src/query-performance-monitoring/common-utils/common-helpers.go

src/query-performance-monitoring/common-utils/query-fetch-helpers.go

src/query-performance-monitoring/performance-metrics/execution_plan_metrics.go

src/query-performance-monitoring/queries/queries.go

src/query-performance-monitoring/query_performance_main.go

tharun0064

@rajrohanyadav
Thanks for reviewing the PR
can you mention the comments with criticality as P0 ,P1 etc
we will work on them accordingly

rajrohanyadav · 2025-01-09T15:27:49Z

@rajrohanyadav Thanks for reviewing the PR can you mention the comments with criticality as P0 ,P1 etc we will work on them accordingly

P0 - Unit tests
P1 - Everything else (that we can accomplish) :)

tharun0064

@rajrohanyadav
Added unit test-cases

src/main.go

src/query-performance-monitoring/common-utils/common-helpers.go

src/query-performance-monitoring/common-utils/constants.go

src/query-performance-monitoring/common-utils/ingestion-helpers.go

src/query-performance-monitoring/common-utils/query-fetch-helpers.go

src/query-performance-monitoring/query_performance_main.go

src/query-performance-monitoring/performance-metrics/individual_query_metrics.go

src/query-performance-monitoring/performance-metrics/individual_query_metrics_test.go

src/query-performance-monitoring/queries/queries.go

src/query-performance-monitoring/performance-metrics/individual_query_metrics.go

src/query-performance-monitoring/common-utils/common_helpers_test.go

src/query-performance-monitoring/validations/performance_metrics_validations.go

rahulreddy15

Discussed unit testing for Populate functions.

Query performance monitoring undo change remove test query query performance monitoring undo changelog changes Query performance monitoring Query performance monitoring slow query len check in individual queries metrics populate trim query text lint issue fix undo changelog file change test remove OH queries remove OH queries reusing existing DB connection (#22) reusing existing DB connection DB specific metric collection (#23) DB specific metric collection query response time threshold (#24) query response time threshold change in individual query (#25) change in individual query version specific queries (#26) verison specific queries fix database name (#27) fix database name test test min max threshold on limit (#28) min max threshold on limit Feat version specific individual query (#29) * version specific indivual query Feat version specific individual query (#30) Version specific indivual query fix query id , ingestData:false and reuse individual version specific query (#31) fix query id , ingestData:false and reuse individual version specific query database list check (#32) database list check publish only if there are metrics (#33) publish only if there are metrics undo change log change

Refactor : version specific blocking session annonamization

refactor: resolved review comments Co-authored-by: jsurampudi <[email protected]>

* refactor: resolved review comments and lint issues Co-authored-by: tharun0064 <[email protected]>

Refactor : nil checks

resolved review comments

* resolved: review comments

* Integration Testing Setup -- Needs Cleanup * fixed old integration test * tests now check unsupported containers * cleanup and fixed linting errors

feat : resolved review comments

resolved: review comments

* resolved: review comments

Feat: resolved review comments

* Refactored Integration Tests * Fixed linting errors * Fixed linting errors again * Fixed linting errors again again * Fixed linting errors again again again * linting is back * linting is back again * linting is back again again * linting is back again again again * linting is back again again again again

resolved : review comments

fix lint issues

Feat : resolved review comments

* resolved: refactored unit test cases

tharun0064 force-pushed the feat_performance_monitoring branch 3 times, most recently from a3610b4 to a920d40 Compare January 8, 2025 06:47

rahulreddy15 changed the base branch from master to epic_db_query_performance_monitoring January 8, 2025 08:35

rahulreddy15 added the do-not-merge label Jan 9, 2025

rahulreddy15 marked this pull request as ready for review January 9, 2025 04:18

rahulreddy15 requested a review from a team as a code owner January 9, 2025 04:18

rajrohanyadav reviewed Jan 9, 2025

View reviewed changes

tharun0064 reviewed Jan 9, 2025

View reviewed changes

tharun0064 reviewed Jan 15, 2025

View reviewed changes