Step1 - 지하철역 인수 테스트 작성 #1051
Merged
Step1 - 지하철역 인수 테스트 작성 #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
저도 추상화 수준을 맞추어 분리하는 방향이 좋다고 생각해요! :) 그래야 코드를 편하게 읽을 수 있더라구요. 👍 👍 |
hiblue02
approved these changes
Jan 28, 2024
| @Test | ||
| void accessGoogle() { | ||
| // TODO: 구글 페이지 요청 구현 | ||
| ExtractableResponse<Response> response = null; |
There was a problem hiding this comment.
0단계 리뷰사이클 연습 없이 1단계 미션 진행하셨군요! ㅎㅎ
여기도 작성 부탁드려요!
There was a problem hiding this comment.
제가 이 PR 리뷰 요청을 안 드렸네요...!
| @DisplayName("지하철역을 생성한다.") | ||
| @Test | ||
| void create_station() { |
There was a problem hiding this comment.
given, when, then 테스트 시나리오가 사라졌어요 😭
/**
* When 지하철역을 생성하면
* Then 지하철역이 생성된다
* Then 지하철역 목록 조회 시 생성한 역을 찾을 수 있다
*/| // given | ||
| createStation(createBody("강남역1")); | ||
| createStation(createBody("강남역2")); |
There was a problem hiding this comment.
반복해서 쓰이는 매직리터럴은 상수로 선언하면 어떨까요?
| } | ||
|
|
||
| private ExtractableResponse<Response> createStation(Map<String, String> params) { |
Comment on lines
+46
to
+47
| assertThat(stationNames).containsAnyOf("강남역2"); |
There was a problem hiding this comment.
containsAnyOf는 파라미터를 array로 받을 수 있어요.
assertThat(stationNames).containsAnyOf("강남역1", "강남역2");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요!
인수 테스트를 작성하다보니, 반복되는 부분(생성, 조회) 이 발생해서 이 부분을 별도의 메서드로 분리했습니다.
삭제같은 경우는 한 번밖에 나오지는 않았지만, 추상화 수준(..?)을 맞춰야지(생성이 메서드로 분리되어 있어) 읽기가 더 편한 것 같아 삭제도 별도의 메서드로 분리하였습니다.