[Spring JDBC] 한명수 미션 제출합니다. #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요 명수님! 군더더기 없이 깔끔한 코드라 리뷰할 점이 거의 보이지 않았습니다..! 도메인 객체의 Id를 Repository에서 주입해도 될까? 코드 보면서 많이 배워갑니다 :) |
Kyuwon-Choi
reviewed
May 21, 2024
There was a problem hiding this comment.
추상화 하여 repository를 분리해 깔끔하게 잘 보이네요!
Kyuwon-Choi
reviewed
May 21, 2024
There was a problem hiding this comment.
findById 메서드는 삭제시에만 사용하는 것 처럼 보이는데 delete 메서드와 구분하여 따로 만드신 이유가 있는걸까요? 궁금합니다!
There was a problem hiding this comment.
findById는 이후에 다시 사용될 로직이라 생각해서 따로 분리해서 만들었습니다 :)
Kyuwon-Choi
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님.
미션 수행하느라 수고 많으셨습니다!
편하게 리뷰 작성해주시면 감사하겠습니다. (꾸벅)
✅ 같이 고민하고 싶은 점
Id를Repository에서 주입해도 될까?✅ 중점으로 봐주셨으면 하는 점
Files changed에는컨트롤러,DTO등이 포함되지 않습니다.Spring JDBC 미션 커밋 범위