Merge pull request #168 from next-tms/format-package-new-dimensions

Prevent prematurely processing `dimensions` on `Package.new`
next-tms · Nov 17, 2024 · 8872249 · 8872249
2 parents bfb2663 + a275e93
commit 8872249
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/freight_kit/package.rb b/lib/freight_kit/package.rb
@@ -39,17 +39,14 @@ def initialize(total_grams_or_ounces, dimensions, packaging_type, options = {})
       raise ArgumentError, 'Package#new: packaging_type is required' unless packaging_type
       raise ArgumentError, 'Package#new: quantity is required' unless options[:quantity]
 
-      @dimensions = case dimensions
-                    when Array
-                      dimensions.map(&:presence)
-                    when Hash
+      @dimensions = if dimensions.is_a?(Hash)
                       [
                         dimensions[:height].presence,
                         dimensions[:width].presence,
                         dimensions[:length].presence,
                       ]
                     else
-                      [nil, nil, nil]
+                      dimensions
                     end
 
       @description = options[:description]