refactor: move as discovery to normalize providers #11170
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11170 +/- ##
==========================================
+ Coverage 40.10% 40.14% +0.04%
==========================================
Files 178 178
Lines 28527 28589 +62
Branches 1240 1248 +8
==========================================
+ Hits 11440 11478 +38
- Misses 17087 17111 +24 ☔ View full report in Codecov by Sentry. |
ThangHuuVu
force-pushed
the
refactor/authorize-url-todos
branch
from
4c666e2
to
27cbb18
Compare
| if (c.issuer) { | ||
| const issuer = new URL(c.issuer) | ||
| try { | ||
| const discoveryResponse = await o.discoveryRequest(issuer) |
There was a problem hiding this comment.
we can cache this in the module scope to potentially hit it less
There was a problem hiding this comment.
Not sure what do you mean by "module scope" but I implemented the caching mechanism with the cookies. My worry is that this could be considered bloat :/
There was a problem hiding this comment.
another solution is to make authorization become a lazy function for oidc providers. Technically, it's not much different with the original code, just move the discovery function call to providers, and parseProviders won't need to be async either. This is the first solution I've thought of.
Co-authored-by: Balázs Orbán <[email protected]>
☕️ Reasoning
Addressing some TODOs in
authorization-urlandproviders:OAuthConfigInternal['authorization']now returns aURLandAuthorizationServerif the provider type isoidc.c.authorizationis empty for OAuth 2 providers🧢 Checklist
🎫 Affected issues
📌 Resources