Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove js file from dist and use only provide Typescript definitions #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove js file from dist and use only provide Typescript definitions #242

wants to merge 1 commit into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 29, 2023

No description provided.

ChristophWurst
ChristophWurst reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smells like a breaking change?

@susnux
Copy link
Contributor Author

susnux commented Dec 3, 2023

Smells like a breaking change?

Could be (should not break but could be). So I would like to include #241 and then release 1.8 and do this for 2.0 afterwards?

@ChristophWurst
Copy link
Contributor

Sounds good

@susnux susnux mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @ChristophWurst