-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create scrollable content via min-height
over sidebar and settings …
#4825
Create scrollable content via min-height
over sidebar and settings …
#4825
Conversation
sorry lets revert you fixup comment, my comment was wrong. If we set this on the dialog even small text dialogs have at least that height which looks weird. |
…dialog on small screens Signed-off-by: julia.kirschenheuter <[email protected]>
fbe8c6a
to
73fa6b1
Compare
Isn’t there being 2 scrollable contents right within each other quite a no-go? Having to scroll twice and the possibility of getting those mixed up (and have content hidden) is quite confusing. |
Yes, there will be 2 scrollable contents. But this is the easiest solution we found to make pages usable on a 320x256 screen (a11y requirement). As an alternative to the settings dialog, we could remove Do you have any ideas? @jancborchardt |
Will this 2-scrollable-areas situation only appear at these small sizes or before already? If only at these small sizes I'd say it's fine. If it appears for everyone even at desktop size or a bit smaller screen (considering sidebar is only a part of it), we'd have to check. |
Before. The minimal height for content was 0px before, which is unreadable. With this PR it is 256px. It depends on sidebar content, but for a file nav header + sidebar header + tabs + padding = ~310px. So it adds scrolling from ~570px. What the minimal height could you suggest for the sidebar content? |
Create scrollable content via
min-height
over sidebar and settings dialog on small screens☑️ Resolves
As suggested [BITV] 9.1.4.10/6.2 - At a browser window width of 320 CSS pixels (or at a browser window width of 1280 CSS pixels and 400% zoom magnification), the page contents do not wrap - some information and functions are not available without users having to scroll horizontally. (1) nextcloud/server#36965 (comment)
🖼️ Screenshots
🏚️ Before
🏡 After
🏁 Checklist