-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] fix(NcAppNavigationItem): run cypress tests #4853
Conversation
b3762d4
to
6bdbaec
Compare
27d92b2
to
90cffb2
Compare
a2c19c4
to
b22d9cf
Compare
Seems like a runtime version of Vue is used instead of full with compiler. (Or ESM version instead of CJS, because in CJS there is no separation between runtime and full bundle). |
Indeed, that is the issue. Any idea how to fix it? I couldn't find anything in the cypress docs. |
Weird bad simple solution: in the test import import { defineComponent } from 'vue/dist/vue.esm-bundler.js' Better solution could be to specify config in Cypress: // ...
import { mergeConfig } from 'vite'
import viteConfig from './vite.config.mts'
export default defineConfig({
// ...
devServer: {
framework: 'vue',
bundler: 'vite',
viteConfig: mergeConfig(viteConfig, {
resolve: {
alias: {
vue: 'vue/dist/vue.esm-bundler.js',
},
},
}),
},
},
}) But in the current setup with using TS in configs it is not possible to import vite config from cypress config. And another alternative could be to define env in cypress config and modify vite config based on env. |
Signed-off-by: Raimund Schlüßler <[email protected]>
b22d9cf
to
5bc187c
Compare
I think this is good enough for now. I adjusted the PR accordingly. |
Ping. |
☑️ Resolves
NcAppNavigationItem
.