Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/Make name longer when actions menu isn't visible #4911

Closed
wants to merge 5 commits into from
Closed

Enh/Make name longer when actions menu isn't visible #4911

wants to merge 5 commits into from

Conversation

GVodyanov
Copy link
Contributor

Make name longer when actions menu isn't visible by not displaying app-navigation-entry__utils when not needed

Useful for nextcloud/mail#7171

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

ShGKme
ShGKme requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Grigory!

Hiding actions makes sense, but we should not hide the counter.

To make changes to stable7 (if it is not a specific v7.x bug), the fix should be applied to the current master first and then backported to stable7 if needed.

src/components/NcAppNavigationItem/NcAppNavigationItem.vue Outdated Show resolved Hide resolved
@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress feature: app-navigation Related to the app-navigation component labels Dec 4, 2023
@GVodyanov GVodyanov mentioned this pull request Dec 7, 2023
Closed
2 tasks
@GVodyanov GVodyanov closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme requested changes

Assignees

@GVodyanov GVodyanov

Labels
2. developing Work in progress enhancement New feature or request feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GVodyanov @ShGKme