-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(NcSelect): Add visible input label #4963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, fantastic PR. Just would recommend squashing the first, third, and fourth PR's together because they are to do with the actual template, and leave the second commit as it, because its to do with doc descriptions : )
heres a link on how to squash the commits even if they are not in order - dunno if you need this but I personally did not know you could squash out of order commits. Once that's done, this PR is good!
I'd like to keep the current logical separation of commits, will be a merge commit anyways :) |
If I understand all correctly, with a new prop, we have two props that have a meaning of the component label:
And to avoid a11y issues:
I think we should either add a validation here to check both conditions, or we should mark |
73673ca
to
03c39d3
Compare
Warnings added without the deprecation as I think we should still allow setting ariaLabelCombobox, but todos have been added for the next major @ShGKme |
Should we not use the same design as for the input boxes, text area ...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe what @susnux said is best, but for now, this LGTM
171d8f4
to
e755a0b
Compare
Can be done separately 💅 |
Signed-off-by: Christopher Ng <[email protected]>
- Remove unnecessary input id Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
e755a0b
to
77de015
Compare
Summary
ariaLabelCombobox
🏁 Checklist