feat(NcAppNavigationItem): make collapsible by clicking on whole component #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent Signed-off-by: Grigory Vodyanov <[email protected]>
susnux
reviewed
Oct 7, 2024
susnux
reviewed
Oct 7, 2024
susnux
reviewed
Oct 7, 2024
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Grigory Vodyanov <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Grigory Vodyanov <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Grigory Vodyanov <[email protected]>
susnux
reviewed
Oct 7, 2024
| // If no links are defined, and collapsing is enabled, we want it to collapse | ||
| if (this.to === null && this.href === null && this.collapsible === true) { | ||
| this.toggleCollapse() | ||
| event.preventDefault() |
There was a problem hiding this comment.
@susnux Sorry for the late reply, but it is needed because there are multiple actions that clicking an AppNavigationItem could trigger. If a link is defined, you go to the link, if not and the component is collapsible, it would collapse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
No graphical changes