make workflow fail also for invalid json file

Signed-off-by: Simon L. <[email protected]>
nextcloud · Jun 27, 2024 · ffcfc06 · ffcfc06
1 parent 16f3acd
commit ffcfc06
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/json-validator.yml b/.github/workflows/json-validator.yml
@@ -30,6 +30,6 @@ jobs:
           for file in "${JSON_FILES[@]}"; do
             json validate --schema-file=php/containers-schema.json --document-file="$file" 2>&1 | tee -a ./json-validator.log
           done
-          if grep -q "document does not validate with schema." ./json-validator.log; then
+          if grep -q "document does not validate with schema.\|invalid JSONFile" ./json-validator.log; then
             exit 1
           fi
diff --git a/community-containers/makemkv/makemkv.json b/community-containers/makemkv/makemkv.json
@@ -27,11 +27,19 @@
                     "writeable": false
                 },
                 {
-                    "source": "%NEXTCLOUD_MOUNT%", --> add note that this needs to be configured, else it will discard it.
+                    "source": "%NEXTCLOUD_MOUNT%", --> add note to readme that this needs to be configured, else it will discard it.
                     "destination": "/output", --> add to readme how to configure this in the makemkv gui (so that e.g. a subdir can be used)
                     "writeable": true
                 }
             ],
+            "environment": [
+                "WEB_AUTHENTICATION=1",
+                "WEB_AUTHENTICATION_USERNAME=root",
+                "WEB_AUTHENTICATION_PASSWORD=%MAKEMKV_PASSWORD%" --> add note to readme how to retreive it
+            ],
+            "secrets": [
+                "MAKEMKV_PASSWORD"
+            ],
             "backup_volumes": [
                 "nextcloud_aio_makemkv"
             ],