Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-containers: add makemkv #4902

Merged
merged 1 commit into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions community-containers/makemkv/makemkv.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
{
"aio_services_v1": [
{
"container_name": "nextcloud-aio-makekv",
"display_name": "MakeMKV",
"documentation": "https://github.com/nextcloud/all-in-one/tree/main/community-containers/makemkv",
"image": "jlesage/makemkv",
"image_tag": "latest",
"internal_port": "5802",
"restart": "unless-stopped",
"ports": [
{
"ip_binding": "",
"port_number": "5802",
"protocol": "tcp"
}
],
"volumes": [
{
"source": "nextcloud_aio_makemkv",
"destination": "/config",
"writeable": true
},
{
"source": "%NEXTCLOUD_DATADIR%",
"destination": "/storage",
"writeable": false
},
{
"source": "%NEXTCLOUD_MOUNT%",
"destination": "/output",
"writeable": true
},
{
"source": "/dev",
"destination": "/dev",
"writeable": false
}
],
"environment": [
"TZ=%TIMEZONE%",
"SECURE_CONNECTION=1",
"WEB_AUTHENTICATION=1",
"USER_ID=33",
"GROUP_ID=33",
"WEB_AUTHENTICATION_USERNAME=makemkv",
"WEB_AUTHENTICATION_PASSWORD=%MAKEMKV_PASSWORD%",
"WEB_LISTENING_PORT=5802"
],
"secrets": [
"MAKEMKV_PASSWORD"
],
"backup_volumes": [
"nextcloud_aio_makemkv"
]
}
]
}
20 changes: 20 additions & 0 deletions community-containers/makemkv/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
## MakeMKV
This container bundles MakeMKV and auto-configures it for you.

### Notes
- This container should only be run in home networks
- ⚠️ This container mounts all devices from the host inside the container in order to be able to access the external DVD/Blu-ray drives which is a security issue. However no better solution was found for the time being.
- This container only works on Linux and not on Docker-Desktop.
- This container requires the [`NEXTCLOUD_MOUNT` variable in AIO to be set](https://github.com/nextcloud/all-in-one?tab=readme-ov-file#how-to-allow-the-nextcloud-container-to-access-directories-on-the-host). Otherwise the output will not be saved correctly..
- After adding and starting the container, you need to visit `https://internal.ip.of.server:5802` in order to log in with the `makemkv` user and the password that you can retrieve when running `sudo docker inspect nextcloud-aio-makemkv | grep WEB_AUTHENTICATION_PASSWORD`. (It uses a self-signed certificate, so you need to accept the warning).
- After the first login, you can adjust the `/output` directory in the MakeMKV settings to a subdirectory of the root of your chosen `NEXTCLOUD_MOUNT`. (by default `NEXTCLOUD_MOUNT` is mounted to `/output` inside the container. Thus all data is written to the root of it)
- The configured `NEXTCLOUD_DATADIR` is getting mounted to `/storage` inside the container.
- The config data of MakeMKV will be automatically included in AIOs backup solution!
- ⚠️ After you are done doing your operations, remove the container for better security again from the stack: https://github.com/nextcloud/all-in-one/tree/main/community-containers#how-to-remove-containers-from-aios-stack
- See https://github.com/nextcloud/all-in-one/tree/main/community-containers#community-containers how to add it to the AIO stack

### Repository
https://github.com/jlesage/docker-makemkv

### Maintainer
https://github.com/szaimen
2 changes: 1 addition & 1 deletion php/containers-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
},
"source": {
"type": "string",
"pattern": "^((nextcloud_aio_[a-z_]+)|(%[A-Z_]+%))$"
"pattern": "^((nextcloud_aio_[a-z_]+)|(%[A-Z_]+%)|(/dev))$"
},
"writeable": {
"type": "boolean"
Expand Down