docker-socket-proxy: allowed read/write/exec of files for AppAPI for ExApps containers #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksander Piskun <[email protected]>
szaimen
changed the title
41 tasks
|
This is now released with v10.1.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for nextcloud/app_api#448 for the upcoming Nextcloud 31 release.
Changes are the same as here: nextcloud/docker-socket-proxy#41
In brief:
PUT containers/%s/archiveallows AppAPI to write files to the ExApp container.POST containers/%s/updatewill allows to change ContainerRestart policy in future. Docker APIPOST containers/%s/execis used to create execution object.POST exec/%sallows to start execution object.First three endpoints is limited to with usual secure mask
nc_app_[a-zA-Z0-9_.-]+to allow access only to ExApps.