-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Prevent passphrase regeneration when switching apps during encry… #13836
base: master
Are you sure you want to change the base?
Fix: Prevent passphrase regeneration when switching apps during encry… #13836
Conversation
…ption setup Signed-off-by: Yuvraj Kumar <[email protected]> Signed-off-by: Yuvraj Kumar <[email protected]> :wq git push --force-with-lease
f32a0f4
to
3eb53f1
Compare
Hi @tobiasKaminsky @alperozturk96 , I've addressed the issue with the passphrase regeneration during encryption setup. The changes are in the pull request. Could you please review and let me know if there are any concerns? If everything looks good, could you merge it? Thank you! |
Hi, thanks for the contribution 💯 I can only see changes in the test file. Could you update the PR? A before-and-after demo would also be great, so we can reproduce the steps exactly. Thanks 👍 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Thank you for your contribution! |
@alperozturk96 @tobiasKaminsky Thank you for the feedback! I’ve double-checked the PR to ensure that all necessary implementation changes are included, especially in EncryptionUtils.java, as well as any relevant test updates. I’ve reviewed the commit history and confirmed that everything is up-to-date with the latest push. If there’s anything specific you’d like me to verify or an additional file I may have missed, please let me know. Happy to make any further adjustments as needed. Thank you! |
I am sorry, but I still do not understand the purpose of this PR as you are only changing code inside test folder. |
Here's a suggested description for your pull request regarding the encryption passphrase issue:
Pull Request Title: Fix Encryption Passphrase Handling
Description:
Issue Overview:
This pull request addresses the issue related to the encryption passphrase handling in our application. Previously, users experienced difficulties in securely managing their encryption keys, which could potentially lead to vulnerabilities.
Changes Made:
Testing:
Impact:
This fix enhances the security of our application by ensuring that encryption passphrases are handled more securely, ultimately providing a better user experience.