Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bulk Action Support to Trashbin #13982

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

surinder-tsys
Copy link
Collaborator

@surinder-tsys surinder-tsys commented Nov 8, 2024

Added bulk action feature to the Trashbin, allowing users to select and manage multiple items at once, enhancing efficiency and user experience.

Refer screenshots:

Default Screen Selection Mode Single Selection Multiple Selection
  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member

👍 Thank you for your contribution.
Works very well! 🎉

Just one small nitpick:
image
-> restore deleted file is not a plural
As they can be folders and/or files, maybe go with "items"? Also in headline?

@surinder-tsys
Copy link
Collaborator Author

@tobiasKaminsky Can we update the Restore deleted file text to Restore?
This will be easy to do as to update the Action title on the fly is kind of tricky.
The options I see:

  1. Have another action item under FileAction and then show hide depending on files selection.
  2. Update the text in ViewModel while showing views.

Can you provide your thoughts on this?

Copy link

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6161
Dodgy code297297
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total510510

Copy link

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants