Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete proguard #3028

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Delete proguard #3028

merged 1 commit into from
Sep 12, 2018

Conversation

tobiasKaminsky
Copy link
Member

As discussed in nextcloud/android-library#160 proguard.cfg is not correctly working.
As we do not use it, this should be removed.

As discussed in nextcloud/android-library#160 proguard.cfg is not correctly working.
As we do not use it, this should be removed.
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings9494
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings164
Experimental Warnings4
Internationalization Warnings13
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings125
Security Warnings200
Dodgy code Warnings135
Total694

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings164
Experimental Warnings4
Internationalization Warnings13
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings125
Security Warnings200
Dodgy code Warnings135
Total694

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #3028 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #3028      +/-   ##
=========================================
+ Coverage     6.5%   6.51%   +<.01%     
=========================================
  Files         306     306              
  Lines       29986   29986              
  Branches     4311    4311              
=========================================
+ Hits         1952    1953       +1     
+ Misses      27742   27741       -1     
  Partials      292     292
Impacted Files Coverage Δ
.../third_parties/daveKoeller/AlphanumComparator.java 83.33% <0%> (+1.19%) ⬆️

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Sep 12, 2018

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants