Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mindmap.crt #700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add mindmap.crt #700

wants to merge 1 commit into from

Conversation

admorgan
Copy link

@admorgan admorgan commented Jul 7, 2024

Fork of files_mindmap at https://github.com/admorgan/files_mindmap

Signed-off-by: Austin Morgan <[email protected]>
@mgallien
Copy link
Contributor

mgallien commented Jul 9, 2024

@admorgan I am not really sure having two apps with the same name will work fine.
Please bear with the fact that I am not an expert of the appstore itself.
Could you maybe discuss with the author of the app that you have forked and find a way to not have two apps with the same name ?

@admorgan
Copy link
Author

admorgan commented Jul 9, 2024

I wholeheartedly agree. Unfortunately the author is missing in action and has not responded to requests for a while. I would prefer not to fork, but I also use this app every day and the version in the parent repo does not work with NC after 27. See ACTom/files_mindmap#191 and ACTom/files_mindmap#197.

Would it be better if I just renamed the whole app to something different? I thought it would be disingenous as I plan to keep the features of the app the same.I am willing to do what it takes to keep using this app.

@mgallien
Copy link
Contributor

@admorgan I am looking into this (what would be needed to get you to be able to publish new releases)
sorry for the delay
did you try reaching out directly (via github and/or emails) to the original author ?
I can see that there is not much activity into those github issues

@admorgan
Copy link
Author

@mgallien I have attempted to DM and e-mail ACTom, but have not received any response in many months. I have another option that may work better for everyone involved. I can just change the name of the application to mindmap2. ACTom's vs version doesn't work with 28 and above. I can only release binaries for 28+ and then there wouldn't be any overlap despite there being functionally two of the same app. My worry is that ACTom eventually comes back and start making releases again some day. While I can update the name of the application, I am not sure how much work it would be to ensure both apps wouldn't interfere with each other if they were both installed at the same time.

@mgallien
Copy link
Contributor

mgallien commented Aug 5, 2024

@mgallien I have attempted to DM and e-mail ACTom, but have not received any response in many months. I have another option that may work better for everyone involved. I can just change the name of the application to mindmap2. ACTom's vs version doesn't work with 28 and above. I can only release binaries for 28+ and then there wouldn't be any overlap despite there being functionally two of the same app.

so from my understanding, renaming is up to you as long as the app id are different, both app can be published on app store

My worry is that ACTom eventually comes back and start making releases again some day. While I can update the name of the application, I am not sure how much work it would be to ensure both apps wouldn't interfere with each other if they were both installed at the same time.

I would suggest to open a github issue on the original repository writing your plan and asking @ACTom what are their plans
that way, if he works again on it, he cannot miss what you are doing

@camilasan camilasan self-assigned this Aug 6, 2024
@camilasan camilasan removed their assignment Sep 5, 2024
@onny onny mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants