Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable/disable increased to 60. Signed-off-by: Alexander Piskun <[email protected]>
|
/backport to stable30 |
kyteinsky
approved these changes
Oct 31, 2024
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/430/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable30Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Oct 31, 2024
Closed
Closed
|
/backport to stable29 |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/430/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8b0c59e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/430/stable29Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This was referenced Oct 31, 2024
bigcat88
added a commit
that referenced
this pull request
Oct 31, 2024
After the previous PR(#430) which added stopping application containers feature when shutting down, as @andrey18106 correctly noted during our 1:1 conversation: we cannot rely on the application inside the docker container to be ready to process the request at the moment the docker container is turned on. This PR introduces handling of it by checking health-check and heartbeat. Signed-off-by: bigcat88 <[email protected]>
bigcat88
added a commit
that referenced
this pull request
Oct 31, 2024
Added stopping of docker containers when ExApp is disabling. Timeout of enable/disable increased to 60. Manual backport of #430 Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ExApp is resource-heavy, stopping it now does not always free up resources (only if it is implemented in ExApp itself, which is quite rare)
That is why we add this PR to turn off the docker container when clicking the "disable" button on ExApp.
With "manual installation" - nothing changes, we have nothing to turn off and this is not supported.
Also, the timeout for a request to ExApp to turn on/off has been raised from 30 seconds to 60 seconds, which is still acceptable for UI so as not to seem slow;
Resolves: #410