Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #475

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #475

merged 1 commit into from
Dec 23, 2024

Conversation

nickvergessen
Copy link
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\AppAPI\Notifications\ExAppNotifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself

@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@nickvergessen nickvergessen merged commit fe0b180 into main Dec 23, 2024
31 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notification-handling branch December 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

@bigcat88 bigcat88 Awaiting requested review from bigcat88

Assignees

@nickvergessen nickvergessen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @andrey18106