Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(talkintegration): add object type to talk room creation #6768

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

miaulalala
Copy link
Contributor

For nextcloud/spreed#14401 we need an object type for the calendar- created Talk rooms.

This PR adds the object type "event" and passes is as an objectType when creating a talk room. Since there is only one room type created directly from the calendar, it should be ok to have this as a static value (same as the room type always being 3).

@st3iny is there any chance to also pass the UUID for the objectId? I'm guessing it doesn't exists yet at this point in the process?

@miaulalala miaulalala added the 3. to review Waiting for reviews label Feb 25, 2025
@miaulalala miaulalala self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.00%. Comparing base (9d76c8c) to head (85bec05).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6768   +/-   ##
=========================================
  Coverage     23.00%   23.00%           
  Complexity      476      476           
=========================================
  Files           252      252           
  Lines         12174    12174           
  Branches       2330     2330           
=========================================
  Hits           2801     2801           
  Misses         9034     9034           
  Partials        339      339           
Flag Coverage Δ
javascript 14.58% <ø> (ø)
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SebastianKrupinski
Copy link
Contributor

SebastianKrupinski commented Feb 25, 2025

@miaulalala Hey Hey! Long time!

@st3iny is there any chance to also pass the UUID for the objectId? I'm guessing it doesn't exists yet at this point in the process?

The UI creates the ID and UID fo the object so it would be possible. We would just need to check if both of those are created at button click or creation of the new object. Either way it is possible.

@miaulalala miaulalala force-pushed the feat/add-object-type-to-calendar-talk-rooms branch from a369e11 to 85bec05 Compare February 27, 2025 11:50
@miaulalala miaulalala enabled auto-merge February 27, 2025 11:50
@miaulalala miaulalala merged commit a8bf478 into main Feb 27, 2025
47 checks passed
@miaulalala miaulalala deleted the feat/add-object-type-to-calendar-talk-rooms branch February 27, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants