-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple merge delete #2756
base: main
Are you sure you want to change the base?
Multiple merge delete #2756
Conversation
82fb27f
to
c498ef2
Compare
Codecov ReportBase: 31.41% // Head: 67.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
=============================================
+ Coverage 31.41% 67.96% +36.54%
Complexity 253 253
=============================================
Files 110 23 -87
Lines 1862 721 -1141
Branches 217 0 -217
=============================================
- Hits 585 490 -95
+ Misses 1162 231 -931
+ Partials 115 0 -115 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eaf43c5
to
396f56c
Compare
Add checkbox on hover and add a button to delete the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>
Add a button to merge the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>
396f56c
to
e89d9a3
Compare
I just rebased this. Hopefully I didn't break anything while doing so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little but important detail missing is handling of address book relations. IMO if all selected contacts belong to the same AB, the merging is OK to do, but across ABs (especially when they are shared) you have to either forbid the operation or ask the user what destination AB they want the merged contact to be written to.
I also don't see any handling of ACLs. It's possible that some ABs are read-only. Then they should probably be ignored for merging as you can neither merge into those contacts nor delete the contact after merging into another AB.
@MrPompom please have a look at #2756 (review). Would that be something you could address? Cheers |
I really would like to have multi contact selection for batch deletion, that would be a very very welcome feature. Without the need of installing Thunderbird. Ps. @MrPompom doesn't seem to be active anymore at all under GitHub. I think it's better to copy his changes and continue in another branch if needed. |
commits to add features linked to :#70 (comment) and #277 (comment)
How it works :
When the mouse is over a contact, the avatar changes to a checkbox.
The checkbox can be checked, when only 1 checkbox is selected, the delete button appears, when it's 2 or more it's a menu with the delete and merge button.
Delete :
When the delete button is clicked, all the selected contacts are deleted
Merge :
When the merge button is clicked, it will merge all the selected contacts into the first selected contact
The value except uid, version, fn, prodid, gender, rev will be added into the first selected contact
The value who already exist and default value will not be added