Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper routing for circles, removing the import button when not needed #4236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GVodyanov
Copy link
Contributor

Fix #4090

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Dec 1, 2024
@GVodyanov GVodyanov requested a review from GretaD December 1, 2024 15:15
@GVodyanov GVodyanov self-assigned this Dec 1, 2024
@GVodyanov GVodyanov requested a review from hamza221 as a code owner December 1, 2024 15:15
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 11.13%. Comparing base (84abda7) to head (a0a80c9).

Files with missing lines Patch % Lines
src/views/Contacts.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4236      +/-   ##
============================================
- Coverage     11.15%   11.13%   -0.02%     
  Complexity      265      265              
============================================
  Files           121      121              
  Lines          5533     5542       +9     
  Branches       1196     1200       +4     
============================================
  Hits            617      617              
- Misses         4794     4804      +10     
+ Partials        122      121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

@GretaD @hamza221 can we get this merged?

src/views/Contacts.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Import contacts" button shows in navigation when a team is selected
3 participants