Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce bundle size, add code splitting #1116

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
+693 −15
Open

Reduce bundle size, add code splitting #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0e57205
Implement naive code splitting
MarcelRobitaille Jul 26, 2022
896a232
Dynamically load moment locales
MarcelRobitaille Jul 26, 2022
0207acc
Ignore calendar-js
MarcelRobitaille Jul 26, 2022
f6226cc
Ignore DatetimePicker
MarcelRobitaille Jul 26, 2022
409bde7
Fix dynamically loading moment locale
MarcelRobitaille Jul 26, 2022
7c4aa37
Only load markdown editor where needed (RecipeView)
MarcelRobitaille Jul 26, 2022
b5de43d
Implement SimpleActionInput
MarcelRobitaille Jul 26, 2022
bf70e55
Remove webpack IgnorePlugins
MarcelRobitaille Jul 26, 2022
6126792
Run prettier
MarcelRobitaille Jul 26, 2022
49d8583
Import moment from @nextcloud/moment
MarcelRobitaille Oct 14, 2022
1c7e883
Fix eslint lints
MarcelRobitaille Oct 14, 2022
8069a70
Fix weird formatting of comment before semicolon
MarcelRobitaille Oct 18, 2022
307b468
Run prettier
MarcelRobitaille Oct 18, 2022
b45f91f
Add attribution to original source of SimpleActionInput
MarcelRobitaille Oct 18, 2022
3624941
Fix tabs and weird comment formatting
MarcelRobitaille Oct 18, 2022
e7f82b6
Run stylelint-fix
MarcelRobitaille Oct 18, 2022
69bfb98
Remove stale comment "markdown" from main
MarcelRobitaille Oct 26, 2022
3113618
Perma-link to ActionInput.vue
MarcelRobitaille Oct 26, 2022
3febd8f
Add back certain functionality of ActionInput.vue
MarcelRobitaille Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/AppControls/AppControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ import NcActions from "@nextcloud/vue/dist/Components/NcActions"
import NcActionButton from "@nextcloud/vue/dist/Components/NcActionButton"
// Cannot use `Button` else get `vue/no-reserved-component-names` eslint errors
import NcButton from "@nextcloud/vue/dist/Components/NcButton"
import NcActionInput from "@nextcloud/vue/dist/Components/NcActionInput"
import NcLoadingIcon from "@nextcloud/vue/dist/Components/NcLoadingIcon"

import PencilIcon from "icons/Pencil.vue"
Expand All @@ -193,6 +192,8 @@ import {
import Location from "./Location.vue"
import ModeIndicator from "./ModeIndicator.vue"

import NcActionInput from "../SimpleActionInput.vue"

export default {
name: "AppControls",
components: {
Expand Down
2 changes: 1 addition & 1 deletion src/components/AppNavi.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
</template>

<script>
import NcActionInput from "@nextcloud/vue/dist/Components/NcActionInput"
import NcAppNavigation from "@nextcloud/vue/dist/Components/NcAppNavigation"
import NcAppNavigationItem from "@nextcloud/vue/dist/Components/NcAppNavigationItem"
import NcAppNavigationNew from "@nextcloud/vue/dist/Components/NcAppNavigationNew"
Expand All @@ -98,6 +97,7 @@ import { showSimpleAlertModal } from "cookbook/js/modals"

import AppSettings from "./AppSettings.vue"
import AppNavigationCaption from "./AppNavigationCaption.vue"
import NcActionInput from "./SimpleActionInput.vue"

export default {
name: "AppNavi",
Expand Down
9 changes: 9 additions & 0 deletions src/components/RecipeView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@
</template>

<script>
import Vue from "vue"
import moment from "@nextcloud/moment"
import VueShowdown from "vue-showdown"

import api from "cookbook/js/api-interface"
import helpers from "cookbook/js/helper"
Expand All @@ -269,6 +271,13 @@ import RecipeNutritionInfoItem from "./RecipeNutritionInfoItem.vue"
import RecipeTimer from "./RecipeTimer.vue"
import RecipeTool from "./RecipeTool.vue"

// Markdown for Vue
// Used by RecipeTool, RecipeInstruction, and RecipeIngredient
Vue.use(VueShowdown, {
// set default flavor for Markdown
flavor: "vanilla",
})

export default {
name: "RecipeView",
components: {
Expand Down
Loading