hostedtoolcache directory and environment variables for it #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
Sep 23, 2024
|
thanks @ivaradi |
Signed-off-by: István Váradi <[email protected]>
mgallien
force-pushed
the
hostedtoolcache
branch
from
61e11c2
to
bed9012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang-tidy check on the desktop client repository (and possible others) fails because the Python venv creation command does not find the
libpythonshared library.The reason is that
LD_LIBRARY_PATHis not set to thelibsubdirectory of the Python installation and that Python is not installed under/opt/hostedtoolcache.LD_LIBRARY_PATHcannot be set, because the venv creation command is in theplatisd/clang-tidy-pr-commentsaction, so Python should be installed under/opt/hostedtoolcache.This can be achieved by setting the
AGENT_TOOLSDIRECTORYand/or theRUNNER_TOOL_CACHEenvironment variables to this path in thecontinuous-integration-client-qt6image (used to run the clang-tidy check), which is what this patch does.