-
Notifications
You must be signed in to change notification settings - Fork 2k
fix Unix socket syntax #13173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix Unix socket syntax #13173
Conversation
@@ -336,7 +336,7 @@ Your host server name, for example ``localhost``, ``hostname``, | |||
``hostname.example.com``, or the IP address. | |||
|
|||
To specify a port use ``hostname:####``, for IPv6 addresses use the URI notation ``[ip]:port``. | |||
To specify a Unix socket use ``/path/to/directory/containing/socket``, e.g. ``/run/postgresql/``. | |||
To specify a Unix socket use ``localhost:/path/to/directory/containing/socket`` or ``:/path/to/directory/containing/socket``, e.g. ``localhost:/run/postgresql/``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is generated. Instead you must modify https://github.com/nextcloud/server/blob/master/config/config.sample.php#L123
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nickvergessen, I opened a new PR : nextcloud/server#53327
Guess that will be sufficient ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
admin_manual/configuration_database/linux_database_configuration.rst change is good, the other one needs to be reverted and will come automatically from your server PR
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
@leManu want to do that final change? Or should we do it for you? |
Should be good now @nickvergessen ? |
You would need to squash all commits into one, so you don't touch the conflicting file. If you don't understand what that means, I can also take care of it. |
☑️ Resolves
🖼️ Screenshots