-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ACL): Add check to prevent users from revoking their own access #2960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icewind1991 since you said
Would it maybe make more sense to just fully prevent users from revoking their own access?
I would say the modal is better, because maybe you do want to get out of the group folder?
Access removal
Proceeding will remove your own access to this group folder.
[ Cancel ] [ Remove own access ]
Fixes #2822 |
I don't think this makes sense, since in fact you do not remove yourself from the Team folder this way. |
f38c222
to
f575b16
Compare
Signed-off-by: Robin Appelman <[email protected]> Signed-off-by: provokateurin <[email protected]>
f575b16
to
dc3d8c0
Compare
/backport to stable31 |
When changing ACL rules, check if the new rule set would lead the current user without read permissions
(maybe) add an option to force revoking the access anyway