Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX header #3102

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Add SPDX header #3102

merged 2 commits into from
Aug 9, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Aug 8, 2024

  • Replacing headers with SPDX-headers for REUSE compliance
  • Adding a GH action to check future compliance
  • Adding a status badge to the readme

@AndyScherzinger AndyScherzinger added 2. developing Items that are currently under development technical debt labels Aug 8, 2024
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/reuse-compliance branch from aa49d7f to 5efeda5 Compare August 8, 2024 16:46
@AndyScherzinger
Copy link
Member Author

@zak39 and @StCyr there has been a small amount of files which had an AGPL3(only) header instead of an AGPL3(or-later) header. I expect this has simply be an c&p issue yet wanted to get your feedback/approval that you are fine with the change from AGPL3 to AGPL3+ like all the other files in this repo. Thanks in advance.

@AndyScherzinger AndyScherzinger added 3. to review Items that need to be reviewed and removed 2. developing Items that are currently under development labels Aug 8, 2024
Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/reuse-compliance branch from 5efeda5 to 903e7ab Compare August 8, 2024 17:40
@zak39
Copy link
Contributor

zak39 commented Aug 9, 2024

@zak39 and @StCyr there has been a small amount of files which had an AGPL3(only) header instead of an AGPL3(or-later) header. I expect this has simply be an c&p issue yet wanted to get your feedback/approval that you are fine with the change from AGPL3 to AGPL3+ like all the other files in this repo. Thanks in advance.

Hi @AndyScherzinger :)

I think it was a copy and paste problem, because I see "Groupfolders" instead of "@license GNU AGPL version 3 or any later version". It's strange 😶

Nevertheless, all our files have the @license GNU AGPL version 3 or any later version in the header.

We worked on these files from this Nextcloud 23 documentation : https://docs.nextcloud.com/server/23/developer_manual/getting_started/codingguidelines.html .

Our files are :

  • src/Constants.js
  • lib/Service/FolderFilter.php *
  • lib/Service/ApplicationService.php *
  • src/settings/AdminGroupSelect.tsx
  • src/settings/SubAdminGroupSelect.tsx
  • These files have "Groupfolders" instead of "@license GNU AGPL version 3 or any later version".

I don't think I forgot any other file 🤔

It's okay for me @AndyScherzinger 👍

@StCyr
Copy link
Contributor

StCyr commented Aug 9, 2024

@zak39 and @StCyr there has been a small amount of files which had an AGPL3(only) header instead of an AGPL3(or-later) header. I expect this has simply be an c&p issue yet wanted to get your feedback/approval that you are fine with the change from AGPL3 to AGPL3+ like all the other files in this repo. Thanks in advance.

No problem for me! Thanks for all your good work! 🔥

@AndyScherzinger
Copy link
Member Author

@icewind1991 only 2 cypress tests are failing but they seem unrelated since they also fail on other PRs i.e. https://github.com/nextcloud/groupfolders/actions/runs/10288140194/job/28539422476?pr=3096

@AndyScherzinger AndyScherzinger merged commit d46a561 into master Aug 9, 2024
45 of 47 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/reuse-compliance branch August 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants