test: Fix cypress tests #3406
Merged
test: Fix cypress tests #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
test/fix-cypress
branch
from
356224f to
fac954b
Compare
|
Ok, the preview icon errors seem to be real problems, not only locally. |
provokateurin
added
2. developing
provokateurin
force-pushed
the
test/fix-cypress
branch
from
fac954b to
2d01544
Compare
provokateurin
added
3. to review
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
test/fix-cypress
branch
from
2d01544 to
124214d
Compare
sorbaugh
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still see some failures locally, but I think they might just be local problems that are not going to happen in CI 🤷♀️
I updated the filesUtils.ts from server and also migrated some of the tests to use these helpers where possible to ease maintaining them in the future.