chore(nextcloud): migrate lint rules

Signed-off-by: Nikolas Rimikis <[email protected]>
nextcloud · Dec 20, 2023 · 1ecb4d8 · 1ecb4d8
1 parent 4e5e450
commit 1ecb4d8
Show file tree

Hide file tree

Showing 49 changed files with 4,628 additions and 4,831 deletions.
diff --git a/packages/dynamite/dynamite/lib/src/builder/client.dart b/packages/dynamite/dynamite/lib/src/builder/client.dart
@@ -483,7 +483,7 @@ Iterable<String> buildAuthCheck(
   yield '''
 // coverage:ignore-start
 final authentication = $client.authentications.firstWhereOrNull(
-    (final auth) => switch (auth) {
+    (auth) => switch (auth) {
 ''';
 
   yield* securityRequirements.map((final requirement) {

diff --git a/packages/nextcloud/analysis_options.yaml b/packages/nextcloud/analysis_options.yaml
@@ -1,7 +1 @@
 include: package:neon_lints/dart.yaml
-
-linter:
-  rules:
-    # TODO: migrate package to new lint rules
-    prefer_final_parameters: true
-    avoid_final_parameters: false
diff --git a/packages/nextcloud/bin/generate_exports.dart b/packages/nextcloud/bin/generate_exports.dart
@@ -8,9 +8,9 @@ void main() {
   final files = Directory('lib/src/api')
       .listSync()
       .cast<File>()
-      .where((final file) => file.path.endsWith('.openapi.dart'))
+      .where((file) => file.path.endsWith('.openapi.dart'))
       .toList()
-    ..sort((final a, final b) => a.path.compareTo(b.path));
+    ..sort((a, b) => a.path.compareTo(b.path));
 
   final idStatements = StringBuffer();
 

diff --git a/packages/nextcloud/bin/generate_props.dart b/packages/nextcloud/bin/generate_props.dart
@@ -1,7 +1,7 @@
 import 'dart:io';
 
 void main() {
-  final props = File('lib/src/webdav/props.csv').readAsLinesSync().map((final line) => line.split(','));
+  final props = File('lib/src/webdav/props.csv').readAsLinesSync().map((line) => line.split(','));
   final valueProps = <String>[];
   final findProps = <String>[];
   final variables = <String>[];
@@ -58,33 +58,33 @@ void main() {
 }
 
 List<String> generateClass(
-  final String name,
-  final String elementName,
-  final String namespace,
-  final List<String> props,
-  final List<String> variables, {
-  required final bool isPropfind,
+  String name,
+  String elementName,
+  String namespace,
+  List<String> props,
+  List<String> variables, {
+  required bool isPropfind,
 }) =>
     [
       '@annotation.XmlSerializable(createMixin: true)',
       "@annotation.XmlRootElement(name: '$elementName', namespace: $namespace)",
       'class $name with _\$${name}XmlSerializableMixin {',
       '  $name({',
-      ...variables.map((final variable) => '    this.$variable,'),
+      ...variables.map((variable) => '    this.$variable,'),
       '  });',
       '',
       if (isPropfind) ...[
         '  $name.fromBools({',
-        ...variables.map((final variable) => '    final bool $variable = false,'),
-        '  }) : ${variables.map((final variable) => '$variable = $variable ? [null] : null').join(', ')};',
+        ...variables.map((variable) => '    bool $variable = false,'),
+        '  }) : ${variables.map((variable) => '$variable = $variable ? [null] : null').join(', ')};',
         '',
       ],
-      '  factory $name.fromXmlElement(final XmlElement element) => _\$${name}FromXmlElement(element);',
-      ...props.map((final prop) => '\n  $prop'),
+      '  factory $name.fromXmlElement(XmlElement element) => _\$${name}FromXmlElement(element);',
+      ...props.map((prop) => '\n  $prop'),
       '}',
     ];
 
-String convertNamespace(final String namespacePrefix) {
+String convertNamespace(String namespacePrefix) {
   switch (namespacePrefix) {
     case 'dav':
       return 'namespaceDav';

diff --git a/packages/nextcloud/lib/src/api/comments.openapi.dart b/packages/nextcloud/lib/src/api/comments.openapi.dart
@@ -23,7 +23,7 @@ class Client extends DynamiteClient {
     super.authentications,
   });
 
-  Client.fromClient(final DynamiteClient client)
+  Client.fromClient(DynamiteClient client)
       : super(
           client.baseURL,
           baseHeaders: client.baseHeaders,
@@ -40,15 +40,14 @@ abstract interface class $Capabilities_FilesInterface {
 
 abstract class Capabilities_Files
     implements $Capabilities_FilesInterface, Built<Capabilities_Files, Capabilities_FilesBuilder> {
-  factory Capabilities_Files([final void Function(Capabilities_FilesBuilder)? b]) = _$Capabilities_Files;
+  factory Capabilities_Files([void Function(Capabilities_FilesBuilder)? b]) = _$Capabilities_Files;
 
   // coverage:ignore-start
   const Capabilities_Files._();
   // coverage:ignore-end
 
   // coverage:ignore-start
-  factory Capabilities_Files.fromJson(final Map<String, dynamic> json) =>
-      jsonSerializers.deserializeWith(serializer, json)!;
+  factory Capabilities_Files.fromJson(Map<String, dynamic> json) => jsonSerializers.deserializeWith(serializer, json)!;
   // coverage:ignore-end
 
   // coverage:ignore-start
@@ -64,14 +63,14 @@ abstract interface class $CapabilitiesInterface {
 }
 
 abstract class Capabilities implements $CapabilitiesInterface, Built<Capabilities, CapabilitiesBuilder> {
-  factory Capabilities([final void Function(CapabilitiesBuilder)? b]) = _$Capabilities;
+  factory Capabilities([void Function(CapabilitiesBuilder)? b]) = _$Capabilities;
 
   // coverage:ignore-start
   const Capabilities._();
   // coverage:ignore-end
 
   // coverage:ignore-start
-  factory Capabilities.fromJson(final Map<String, dynamic> json) => jsonSerializers.deserializeWith(serializer, json)!;
+  factory Capabilities.fromJson(Map<String, dynamic> json) => jsonSerializers.deserializeWith(serializer, json)!;
   // coverage:ignore-end
 
   // coverage:ignore-start