Merge pull request #2401 from nextcloud/fix/neon_framework/app-icon-s…

…emantics
nextcloud · Aug 17, 2024 · 2411736 · 2411736
2 parents 619d391 + 5bd82e1
commit 2411736
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 92 deletions.
diff --git a/packages/neon_framework/lib/src/models/app_implementation.dart b/packages/neon_framework/lib/src/models/app_implementation.dart
@@ -163,15 +163,18 @@ abstract class AppImplementation<T extends Bloc, R extends AppImplementationOpti
       Builder(
         builder: (context) {
           final realSize = size ?? IconTheme.of(context).size;
-          return VectorGraphic(
+          final child = VectorGraphic(
             width: realSize,
             height: realSize,
             colorFilter: ColorFilter.mode(color ?? Theme.of(context).colorScheme.primary, BlendMode.srcIn),
             loader: AssetBytesLoader(
               'assets/app.svg.vec',
               packageName: '${id}_app',
             ),
-            semanticsLabel: NeonLocalizations.of(context).nextcloudLogo,
+          );
+
+          return ExcludeSemantics(
+            child: child,
           );
         },
       );

diff --git a/packages/neon_framework/lib/src/widgets/app_implementation_icon.dart b/packages/neon_framework/lib/src/widgets/app_implementation_icon.dart