Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make blocs non-internal do force documenting the interface #1372

Closed
provokateurin opened this issue Dec 28, 2023 · 1 comment · Fixed by #1374
Closed

Make blocs non-internal do force documenting the interface #1372

provokateurin opened this issue Dec 28, 2023 · 1 comment · Fixed by #1374
Assignees
@provokateurin
Labels
package: neon_framework refactoring Something that needs to be refactored

Comments

@provokateurin
Copy link
Member

Follow up to #1342, this will force use to document the public interface.
@provokateurin provokateurin added package: neon_framework refactoring Something that needs to be refactored labels Dec 28, 2023
@provokateurin provokateurin self-assigned this Dec 28, 2023
@provokateurin
Copy link
Member Author

Actually we can't use @visibleForTesting, as it will also trigger on legitimate uses. We can only make the factory internal.

@provokateurin provokateurin changed the title Remove @internal annotation for blocs and use @visibleForTesting instead Make blocs non-internal do force documenting the interface Dec 28, 2023
@provokateurin provokateurin mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@provokateurin provokateurin

Labels
package: neon_framework refactoring Something that needs to be refactored
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Only make bloc factories internal nextcloud/neon
1 participant
@provokateurin