Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Only make bloc factories internal #1374

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

provokateurin
Copy link
Member

Closes #1372

For the neon_* packages this has not effect since they still have the global ignore set (which we should change eventually).

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that hard to write propper documentation here and we should do so moving forward.

@provokateurin
Copy link
Member Author

I agree and I plan to do that, but for now I only want to change this to enable it. I'll create another issue to document all the blocs.

@provokateurin
Copy link
Member Author

As the commit says this is only a refactor to enabled easier detection of missing docs. I do not want to add the docs in this PR already.

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still disagree.
It's not a big deal to add a few lines of docs. I fear that any open issue will just rot (similar to #1119)

@provokateurin provokateurin merged commit 3025331 into main Dec 29, 2023
8 checks passed
@provokateurin provokateurin deleted the refactor/internal-bloc-factories branch December 29, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make blocs non-internal do force documenting the interface
2 participants