Feat/named records #1044
Merged
Feat/named records #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested changes
Oct 28, 2023
Leptopoda
force-pushed
the
feat/named_records
branch
from
ffb5daf to
8f760fc
Compare
provokateurin
requested changes
Oct 28, 2023
Leptopoda
force-pushed
the
feat/named_records
branch
from
8f760fc to
b305416
Compare
|
I forgot to adjust the doc comment sorry. |
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/named_records
branch
from
b305416 to
559e122
Compare
provokateurin
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How didn't we use named records earlier?
Our dialogs are still untouched but I'd rather add it to #998