Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dev container #1067

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Refactor dev container #1067

merged 3 commits into from
Nov 1, 2023

Conversation

provokateurin
Copy link
Member

  • Improves our Talk tests performance because we don't need to use slow apache anymore
  • Dev server doesn't crash anymore when resizing terminal
  • Static files (news RSS feeds) are served using the dev server for increased performance and less clutter in the tests
  • Tests don't try to build the docker image anymore for decreased start up time

@provokateurin provokateurin force-pushed the refactor/dev-container branch from 4c64dcd to 5051ce1 Compare November 1, 2023 09:09
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we have to manually rebuild the dev container every once in a while?
If so I dislike this approach.

@provokateurin
Copy link
Member Author

It is automatically rebuilt when you run ./tool/dev.sh. The problem with building it inside the tests is that all suites try to do it at the same time and then you end up building the image 8 times in parallel. It also doesn't utilize the GHCR cache, so it's even slower. Relying on the image already being available is much better in my opinion (and we have an error message if it is missing).

@provokateurin provokateurin merged commit 02a1ec6 into main Nov 1, 2023
@provokateurin provokateurin deleted the refactor/dev-container branch November 1, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants